Contributing¶
Want to contribute or make a suggestion? Feel free. But don’t forget to adhere to the guidelines and expectations set forth in the Contributor Covenant.
We follow Git Flow branching strategy to maintain a clean and organized development workflow. Post your questions at the project’s GitHub Page. Remember: there are no stupid questions, only stupid silences.
Development Setup¶
If it’s your first time working on this library, clone the repo and make sure first that you can successfully run tests on your local machine. If that doesn’t work out of the box, please check your local development environment before filing an issue.
$ git clone https://github.com/jmanprz/pypipedrive.git
$ cd pypipedrive
$ make test
Or use tox for multi-environment testing:
$ tox
Git Flow Branching Strategy¶
We follow Git Flow for our branching model. This ensures a clean history and organized releases.
Branch Types:
Type |
Purpose |
Base Branch |
Naming |
|---|---|---|---|
Feature |
New feature development |
|
|
Bugfix |
Bug fixes |
|
|
Hotfix |
Production fixes |
|
|
Docs |
Documentation updates |
|
|
Chore |
Maintenance, dependencies |
|
|
Refactor |
Code refactoring |
|
|
Test |
Test improvements |
|
|
Workflow:
Create a branch from the appropriate base branch
Make your changes and commit with signed commits
Push your branch and open a Pull Request targeting the base branch
Request review and ensure all checks pass
Merge once approved
Examples:
feature/add-entity-mailbox— New mailbox entitybugfix/fix-entity-mailbox-attributes— Mailbox attribute fixhotfix/security-patch-v1.0.3— Production security fixdocs/update-getting-started— Documentation updaterefactor/deprecate-v1-api-client— Code improvement
Reporting a bug¶
Submit an issue to let the community know about bugs. The Pipedrive API evolves constantly, specially in their current V1 to V2 migration.
Make sure to follow these steps along the submission:
You’re on the latest version of the library and you’re able run the test suite locally.
Check open issues for a duplicate issue.
Provide context: expected vs. actual behavior, steps to reproduce, and runtime environment.
When possible, provide code to reproduce the problem that you can share in the issue summary.
For security vulnerabilities, share them _directly_ to the maintainers via email.
Submitting a patch¶
You’re welcome to submit a pull request for a bug fix or a new feature.
All pull requests must adhere to the following guidelines:
Branch follows the naming conventions outlined above and created from the appropriate base branch.
Public functions/methods have docstrings and type annotations.
New functionality is accompanied by clear, descriptive unit tests.
Code passes
make test.You have your commits signed.
No merge conflicts with the target branch.
Don’t hesitate to open a draft pull request when you’re willing to discuss an idea you’re working on but haven’t yet finished all of the above. That’s appreciated and part of the community sharing.
License¶
This project is licensed under the MIT License.
Built by Juan Manuel M. Pérez, Pipedrive API expert from © Magical Potion for teams that need to enhance and customise their Pipedrive sales experience with custom integrations and automations.